search

voxpupuli / puppet-nodejs

Puppet module to install nodejs and global npm packages
https://forge.puppet.com/puppet/nodejs
Apache License 2.0
113 stars 247 forks source link

Add repo_release parameter #349

Closed juniorsysadmin closed 6 years ago

juniorsysadmin commented 6 years ago

Some Debian-derived distributions use their own lsbdistcodename, but work fine when using Debian packages. Add a repo_release parameter to allow users to specify an apt::source release value which matches their Debian family and therefore allow management of the NodeSource repository on those systems.

Supersedes #342

juniorsysadmin commented 6 years ago

Given this is pretty much written by @fnoop it'd be good to use git commit --author and give him the proper credits.

Yeah, I forgot to mention their handle here as well. @fnoop Okay to replace this with you as the commit author?

juniorsysadmin commented 6 years ago

@fnoop Okay to replace this with you as the commit author?

fnoop commented 6 years ago

@juniorsysadmin Really sorry for delay this has been on my todo list but never quite made the top yet! Yes please do whatever you want, I'm not bothered about attribution to me, just to improve the code.

juniorsysadmin commented 6 years ago

@fnoop Okay to replace this with you as the commit author?

Done

fnoop commented 6 years ago

Thanks a lot :)