voxpupuli / puppet-nodejs

Puppet module to install nodejs and global npm packages
https://forge.puppet.com/puppet/nodejs
Apache License 2.0
113 stars 248 forks source link

Wrong repository entry created in Debian stretch #355

Closed hessijames79 closed 6 years ago

hessijames79 commented 6 years ago

How to reproduce (e.g Puppet code you use)

class { 'nodejs': }

What are you seeing

grep deb /etc/apt/sources.list.d/nodesource.list

deb https://deb.nodesource.com/node_0.10 stretch main

apt-get update yields: Err:4 https://deb.nodesource.com/node_0.10 stretch/main amd64 Packages 404 Not Found [...] W: The repository 'https://deb.nodesource.com/node_0.10 stretch Release' does not have a Release file. N: Data from such a repository can't be authenticated and is therefore potentially dangerous to use. N: See apt-secure(8) manpage for repository creation and user configuration details. E: Failed to fetch https://deb.nodesource.com/node_0.10/dists/stretch/main/binary-amd64/Packages 404 Not Found E: Some index files failed to download. They have been ignored, or old ones used instead.

What behaviour did you expect instead

The official installer from https://deb.nodesource.com/setup maps stretch to jessie. Hence, the correct repository entry for (Debian stretch) is: deb https://deb.nodesource.com/node_0.10 jessie main

Output log

Any additional information you'd like to impart

bastelfreak commented 6 years ago

Thanks for rising up this issue. Are you able to provide a patch for it?

juniorsysadmin commented 6 years ago

Hi @hessijames79 , You are right in pointing out that the official installer script maps stretch to jessie, but the stretch folder structure also exists at the apt NodeSource URL. https://github.com/voxpupuli/puppet-nodejs#repo_url_suffix lists the available versions to expect there. Note that 0.10 is an ancient Nodejs version that you probably don't want - some time ago it was the minimum supported by most operating systems so was left as the default in this module. Version 5.0.0 of this module (at the Forge real soon now ) allows one to use the repo_release parameter to override the repository entry with 'jessie' similar to what you have done above, if you still want 0.10

juniorsysadmin commented 6 years ago

8.x is now the default version, which should make things smoother. (See #356)