voxpupuli / puppet-nodejs

Puppet module to install nodejs and global npm packages
https://forge.puppet.com/puppet/nodejs
Apache License 2.0
113 stars 248 forks source link

use_package_json is not idempotent #358

Open fnoop opened 6 years ago

fnoop commented 6 years ago

Affected Puppet, Ruby, OS and module versions/distributions

How to reproduce (e.g Puppet code you use)

nodejs::npm { 'npm-maverick-web':
      user             => 'mav',
      home_dir         => '/srv/maverick',
      ensure           => 'present',
      target           => '/srv/maverick/code/maverick-web',
      use_package_json => true,
    } 

What are you seeing

Notice: /Stage[main]/Maverick_web::Maverick_web/Nodejs::Npm[npm-maverick-web]/Exec[npm_install_npm-maverick-web]/returns: executed successfully This is seen every run

What behaviour did you expect instead

It should only run once