Ubuntu 18.04 gives warning

voxpupuli / puppet-nodejs

Puppet module to install nodejs and global npm packages

https://forge.puppet.com/puppet/nodejs

Apache License 2.0

113 stars 248 forks source link

Ubuntu 18.04 gives warning #361

Closed fnoop closed 6 years ago

fnoop commented 6 years ago

Affected Puppet, Ruby, OS and module versions/distributions

Puppet: 5.5.1
Ruby: 2.5.1
Distribution: Ubuntu 18.04 (bionic beaver)
Module version: latest

How to reproduce (e.g Puppet code you use)

What are you seeing

Warning: Scope(Class[Nodejs::Params]): The nodejs module might not work on Ubuntu 18.04. Sensible defaults will be attempted.

What behaviour did you expect instead

No warning

Any additional information you'd like to impart

It looks like install works because the nodesource repo now exists for bionic.

fnoop commented 6 years ago

Note: Ubuntu 18.04 is now the latest LTS distro, important that it is fully supported now.

bastelfreak commented 6 years ago

Hi @fnoop, thanks for reporting this. Could you try adding acceptance tests for ubuntu 18.04?

fnoop commented 6 years ago

@bastelfreak - Sorry acceptance tests completely baffle me, I have no idea even how to run them. I see in spec/acceptance/nodesets/ I could add an xml file for 18.04, but the files say:

# This file is managed via modulesync
# https://github.com/voxpupuli/modulesync
# https://github.com/voxpupuli/modulesync_config

So I'm guessing adding it manually is the wrong thing to do.

If you could point me in the right direction, be happy to have a go though?

juniorsysadmin commented 6 years ago

Fixed by #362