search

voxpupuli / puppet-nodejs

Puppet module to install nodejs and global npm packages
https://forge.puppet.com/puppet/nodejs
Apache License 2.0
113 stars 248 forks source link

Add support for ubuntu bionic 18.04, #361 #362

Closed fnoop closed 6 years ago

fnoop commented 6 years ago

A tiny fix to support Ubuntu 18.04 LTS (Bionic Beaver)

fnoop commented 6 years ago

Fixes #361

juniorsysadmin commented 6 years ago

Perhaps add a line to metadata.json as well?

bastelfreak commented 6 years ago

@fnoop sadly we can't test this properly on Ubuntu 18.04 yet. Did you test this locally on a 18.04? If so. how did you call the module, with any parameters? If that's the case, could you contribute it to https://github.com/voxpupuli/puppet-nodejs/tree/master/examples ?

fnoop commented 6 years ago

Yes tested locally on 18.04, works fine - it's literally a one character fix. The OS detection/support isn't very robust and will need to be changed for the next Ubuntu release, but works for 18.04. No parameters, it will behave as before as with other OS.

bastelfreak commented 6 years ago

https://github.com/camptocamp/facterdb/pull/82#event-1600066178 spec tests should work soonish

mpdude commented 6 years ago

Could you please release a 5.0.1 to include this?