block creation of File['root_npmrc'] when running on Windows

voxpupuli / puppet-nodejs

Puppet module to install nodejs and global npm packages

https://forge.puppet.com/puppet/nodejs

Apache License 2.0

113 stars 248 forks source link

Closed jhicks-camgian closed 6 years ago

jhicks-camgian commented 6 years ago

File['root_npmrc'] resource causes module to fail on Windows.

juniorsysadmin commented 6 years ago

@jhicks-camgian Can you provide further detail - what Puppet version, log output etc?

jhicks-camgian commented 6 years ago

Puppet 5.5.1 was used but this is an error that would seem to affect any version when used on Windows.

The code under the condition applied in the pull request assumes a Unix user/group schema with a root user.

When applied on a Windows system it attempts to create a '.npmrc' file in /root owned by uid root/gid 0 (which is not possible on Windows).

juniorsysadmin commented 6 years ago

Have created #366 to track a proper fix