search

voxpupuli / puppet-nodejs

Puppet module to install nodejs and global npm packages
https://forge.puppet.com/puppet/nodejs
Apache License 2.0
113 stars 248 forks source link

fix 'nodejs::repo_ensure: absent' for yum #373

Closed bugfood closed 6 years ago

bugfood commented 6 years ago

Presently, setting ensure to 'absent' results in creating two files in /etc/yum.repos.d:

$ cat nodesource.repo [nodesource] $ cat nodesource-source.repo [nodesource-source]

This results in yum failure: $ sudo yum check-update Loaded plugins: fastestmirror, security Repository 'nodesource-source' is missing name in configuration, using id Repository 'nodesource' is missing name in configuration, using id Loading mirror speeds from cached hostfile Error: Cannot find a valid baseurl for repo: nodesource

It is better to ensure these files do not exist. The corresponding apt class is already set up this way.

Note: I was unable to get local tests working for this module. Please test before merging.

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

bugfood commented 6 years ago

I had a bit of trouble with the tests at first, but I think I got it straightened out. Please let me know if there is anything that needs fixing.

Thanks, Corey