voxpupuli / puppet-nodejs

Puppet module to install nodejs and global npm packages
https://forge.puppet.com/puppet/nodejs
Apache License 2.0
113 stars 247 forks source link

Fix idempotence of unquoted secrets #390

Closed aboks closed 5 years ago

aboks commented 5 years ago

Pull Request (PR) description

The fix in https://github.com/voxpupuli/puppet-nodejs/pull/386 fixes idempotence for secrets that contain characters (like '=') that cause NPM to quote them in npmrc. Secrets that end up unquoted in npmrc are not handled correctly however. This fix makes the quotes optional when checking if the config value is already set correctly.

This Pull Request (PR) fixes the following issues

n/a