voxpupuli / puppet-nodejs

Puppet module to install nodejs and global npm packages
https://forge.puppet.com/puppet/nodejs
Apache License 2.0
113 stars 248 forks source link

Avoid collision with other declarations of same resource #391

Closed AlexanderSalmin closed 5 years ago

AlexanderSalmin commented 5 years ago

Pull Request (PR) description

Avoid collision with other declarations of same resource

This Pull Request (PR) fixes the following issues

Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Error while evaluating a Function Call, Duplicate declaration

bastelfreak commented 5 years ago

Hi @AlexanderSalmin, thanks for the PR. I'm not sure if this is a good move. The created repository is pretty module-specific and should not collide. if you manage this already at another place it might make more sense to set manage_package_repo to false in this repository? If we merge your PR, we assume that a repo with the same name contains the correct packages, which will lead to other errors.

juniorsysadmin commented 5 years ago

What @bastelfreak wrote. @AlexanderSalmin Can you explain more about your particular use case?

juniorsysadmin commented 5 years ago

Closing due to no response, feel free to re-open.