voxpupuli / puppet-nodejs

Puppet module to install nodejs and global npm packages

https://forge.puppet.com/puppet/nodejs

Apache License 2.0

113 stars 247 forks source link

Fix global_config_entry dependency on NPM when using nodesource repo #405

Closed wiebe closed 4 years ago

wiebe commented 4 years ago

Pull Request (PR) description

This fixes the npm_config exec in the global_config_entry class not having a dependency on the package that installs NPM when using the nodesource class.

This Pull Request (PR) fixes the following issues

404

wiebe commented 4 years ago

Not sure why the CI build fails, doesn't seem to be because of my change

bastelfreak commented 4 years ago

@wiebe thanks for the PR. Can you take a look at the used email address in the commit? It isn't associated with your github account. Please also add a test for this change.

wiebe commented 4 years ago

My email address should be added to this account now. I rebased and also added tests, everything is green now.