search

voxpupuli / puppet-nodejs

Puppet module to install nodejs and global npm packages
https://forge.puppet.com/puppet/nodejs
Apache License 2.0
113 stars 248 forks source link

Add support for RHEL 8 based distros #413

Closed mmoll closed 4 years ago

mmoll commented 4 years ago

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

ghoneycutt commented 4 years ago

Thanks, great looking PR! Could you also add support to the README under https://github.com/voxpupuli/puppet-nodejs#limitations

mmoll commented 4 years ago

There are still some problems, at least the one with the nodejs package from Nodesource can also be seen on real systems (problem is IMHO in the NodeJS RPM itself), for EPEL, I'll need to have a look...

ghoneycutt commented 4 years ago

Appears to trying to load a template for EPEL8 which does not exist.

mmoll commented 4 years ago

https://github.com/stahnma/puppet-module-epel/pull/92 is waiting for a new module release.

mmoll commented 4 years ago

Fot the nodesource repo to work, yum module disable -y nodejs would be needed (see https://github.com/nodesource/distributions/pull/997). Is there a puppet (non-exec) way to do this?

dhoppe commented 4 years ago

@mmoll As far as I know puppet/yum or puppetlabs/yumrepo_core do not support the handling of modules.

You could use the template resource to create the following file:

[root@1ca0b18b505b ~]# cat /etc/dnf/modules.d/nodejs.module
[nodejs]
name=nodejs
stream=
profiles=
state=disabled
mmoll commented 4 years ago

@dhoppe Thanks for that hint, seems to work well. :bowing_man:

This should be ready for review/merge then.