search

voxpupuli / puppet-nodejs

Puppet module to install nodejs and global npm packages
https://forge.puppet.com/puppet/nodejs
Apache License 2.0
113 stars 248 forks source link

Fix nodejs dev package name for Ubuntu 20.04 . #421 #422

Closed cliffano closed 4 years ago

cliffano commented 4 years ago

Pull Request (PR) description

nodejs-dev package no longer exist for Ubuntu 20.04. It has been replaced by libnode-dev .

This Pull Request (PR) fixes the following issues

Fixes #421

mmoll commented 4 years ago

@cliffano The current Puppet 6 test failures are (AFAICT) unrelated, but could you also add Ubuntu 20.04 to the integration tests? See GH-413 for an example with EL 8.

mmoll commented 4 years ago

Aw, I see... There's also no puppet-agent package from PL at the moment.

ekohl commented 4 years ago

https://github.com/voxpupuli/puppet-nodejs/pull/423 made master green again. Restarted the failed test to see if it passes.

mmoll commented 4 years ago

I extended the tests, together with https://github.com/camptocamp/facterdb/pull/154 this is green now.

ekohl commented 4 years ago

Thanks!

cliffano commented 4 years ago

Thanks for merging. Sorry I've been busy the whole week, was planning to respond over the weekend. Yes, I could only test package changes in 20.04 unfortunately, because as mentioned above, puppet-agent isn't ready yet. This is tracked on https://tickets.puppetlabs.com/browse/PA-3127