search

voxpupuli / puppet-nodejs

Puppet module to install nodejs and global npm packages
https://forge.puppet.com/puppet/nodejs
Apache License 2.0
113 stars 248 forks source link

Drop duplicate class declaration #426

Closed bastelfreak closed 3 years ago

bastelfreak commented 3 years ago

The contain not only enforces the ordering, it also adds it to the catalog. We don't need to call the class explicitly in advance.

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

ekohl commented 3 years ago

wow that's so weird i've never seen something like this … "style" before

It's a valid style and if you need to pass in parameters while also containing it, this is the only way.

However, in this case it's redundant.