voxpupuli / puppet-nodejs

Puppet module to install nodejs and global npm packages
https://forge.puppet.com/puppet/nodejs
Apache License 2.0
113 stars 247 forks source link

Puppet runs Exec[npm_install_NPM dependencies] every run #445

Open ghost opened 3 years ago

ghost commented 3 years ago

Affected Puppet, Ruby, OS and module versions/distributions

How to reproduce (e.g Puppet code you use)

    nodejs::npm { 'NPM dependencies':
        ensure           => present,
        target           => '/var/www/',
        use_package_json => true,
    }

package.json

{
  "name": "MyApp",
  "private": true,
  "version": "0.0.0",
  "description": "a Sails application",
  "keywords": [],
  "dependencies": {
    "archiver": "^0.16.0",
    "ejs": "~0.8.4",
    "fast-csv": "^0.6.0",
    "fs-extra": "^0.26.5",
    "gm": "^1.21.1",
    "grunt": "0.4.2",
    "grunt-contrib-clean": "~0.5.0",
    "grunt-contrib-coffee": "~0.10.1",
    "grunt-contrib-concat": "~0.3.0",
    "grunt-contrib-copy": "~0.5.0",
    "grunt-contrib-cssmin": "~0.9.0",
    "grunt-contrib-jst": "~0.6.0",
    "grunt-contrib-less": "0.11.1",
    "grunt-contrib-uglify": "~0.4.0",
    "grunt-contrib-watch": "~0.5.3",
    "grunt-sails-linker": "~0.9.5",
    "grunt-sync": "~0.0.4",
    "include-all": "~0.1.3",
    "jsdom": "^11.3.0",
    "jsonfile": "^2.2.2",
    "md5": "^2.0.0",
    "mime": "^1.3.4",
    "mime-types": "^2.1.7",
    "nodemailer": "^1.11.0",
    "rc": "~0.5.0",
    "sails": "~0.11.0",
    "sails-disk": "~0.10.0",
    "sails-mongo": "^0.11.4",
    "soap": "^0.11.0",
    "type-of": "^2.0.1",
    "underscore": "^1.8.3",
    "unzip": "^0.1.11",
    "xml2js": "^0.4.15",
    "xmldoc": "^0.4.0"
  },
  "scripts": {
    "start": "node app.js",
    "debug": "node debug app.js"
  },
  "main": "app.js",
  "repository": {
    "type": "git",
    "url": "git://INTERNALREPO"
  },
  "author": "",
  "license": ""
}

What are you seeing

Every puppet run contains Nodejs::Npm[NPM dependencies]/Exec[npm_install_NPM dependencies]/returns: executed successfully (corrective)

What behaviour did you expect instead

Puppet should find no changes

Output log

Any additional information you'd like to impart