Drop support for Debian 9, Ubuntu 16.04 and 18.04, FreeBSD 11, add support for Puppet 8, add support for RHEL 9

voxpupuli / puppet-nodejs

Puppet module to install nodejs and global npm packages

https://forge.puppet.com/puppet/nodejs

Apache License 2.0

113 stars 248 forks source link

Drop support for Debian 9, Ubuntu 16.04 and 18.04, FreeBSD 11, add support for Puppet 8, add support for RHEL 9 #453

Closed bastelfreak closed 9 months ago

bastelfreak commented 2 years ago

modulesync 5.1.0

bastelfreak commented 2 years ago

@smortex looks like CentOS has some package conflicts. Is nodejs still supported there / did we setup the wrong repo / is epel broken maybe?

root-expert commented 2 years ago

Possibly NodeJS on EPEL is dead?

smortex commented 2 years ago

I don't see nodejs-<version>.rpm (only nodejs-<module>-<version>.rpm) on https://mirror.aarnet.edu.au/pub/epel/7/x86_64/Packages/n/ but see it on https://ftp-stud.hs-esslingen.de/pub/Mirrors/archive.fedoraproject.org/epel/6/x86_64/Packages/n/ so maybe yes :shrug:

I guess we just have to axe it in a new breaking change PR.

bastelfreak commented 2 years ago

Hey @sircubbi , do you have any ideas why the tests on CentOS 7 do not pass?

sircubbi commented 2 years ago

Hey @sircubbi , do you have any ideas why the tests on CentOS 7 do not pass?

Hmmm, nothing really catches my eye. Seems like some timeout while still setting up the docker-environment, but no specific cause I fear.

bastelfreak commented 2 years ago

@sircubbi nownthe CI finally failed "properly", adter several docker-related issues. could you take a look again?

sircubbi commented 2 years ago

@sircubbi nownthe CI finally failed "properly", adter several docker-related issues. could you take a look again?

It seems that /usr/bin/npm is not found. If you pull nodejs from EPEL you would also need to install the npm-Package from epel too (when using nodesource that is not necessary, since the npm-Command is already provided by the base-Package).

kenyon commented 9 months ago

I'll work on the EPEL failures. I can clean up the commit log once the code is good and the tests pass.

evgeni commented 9 months ago

This PR contains non modulesync changes:

Drop support for Debian 9, Ubuntu 16.04 and 18.04, FreeBSD 11 (EOL) (breaking)
Add Puppet 8 support (feature)
Add support for RHEL 9 based distros (feature)

How do I teach GHC that…

kenyon commented 9 months ago

Yeah, there were pull requests closed for those, so not sure why GHC didn't include them.