voxpupuli / puppet-vmwaretools

Puppet module to manage VMware Operating System Specific Packages for VMware tools installation.
http://forge.puppetlabs.com/razorsedge/vmwaretools
Apache License 2.0
34 stars 44 forks source link

SLES Support #16

Closed poikilotherm closed 9 years ago

poikilotherm commented 10 years ago

Hi there,

I would like to extend the code for some SLES specific stuff, as we use a lot of SLES server VMs.

As on SLES there is "zypper" as the default and only supported tool, I would like to extend the code to use the zypprepo type created by Darin (https://forge.puppetlabs.com/darin/zypprepo), which was not included into core puppet but published as a module (see Feature #11864 http://projects.puppetlabs.com/issues/11864). Of course this adds a dependency to this module, but it would be really nice to have a real zypper repo.

Kind regards, Poikilotherm

razorsedge commented 10 years ago

I was planning on merging in some of the code in https://github.com/scottjab/puppet-vmwaretools/ . Feel free to send a PR with SuSE support.

poikilotherm commented 10 years ago

Alright, I will take a fork of that code (as it is on 4.1.0 base) and merge in your current master. I'll get the code out to our servers for testing and report back then.

salderma commented 10 years ago

Hi, I was hoping to join in this effort, as I have a few SLES boxes I'm trying to shoehorn into puppet/foreman. And since vmwaretools is applied in one of the top level HostGroups, I'm struggling to get the SLES boxes in there because at the moment it is a $supported platform, so its not skipped, even though support is non-functional.

I was wondering if it wouldn't be a better choice to craft a parameter that represents the repo package url from http://packages.vmware.com/tools/esx/latest/repos/index.html. Then the module could install the package from a URL. This might apply well for all operatingsystems vmware supports.

I'm not completely certain how to craft that URL, but it would seem that once the repo-package is installed, any updates to the repo could be applied by ensuring that package is the "latest".

ashleygould commented 10 years ago

Hi, I just pushed a suse_support branch into my fork yesterday: https://github.com/ashleygould/puppet-vmwaretools/tree/suse_support

It uses zypprepo type (dependancy on darin/zypprepo) on sles systems and corrects the $baseurl_url creation to accomodate how sles repos are named at http://packages.vmware.com/tools/esx/latest/index.html. I am doing more testing on my site before making a pull request. also, I should knuckle down and learn puppet-rspec properly.

I am not entirely happy with how I correct $baseurl_url. It could be much cleaner, but would involve a lot more refactering of existing params.pp. Any suggestion are welcome.

razorsedge commented 10 years ago

@ashleygould After a quick glance at your code, I see that it would need some rspec test modifications to pass unit tests, but otherwise looks OK. I will look more closely at the $baseurl_url munging for any suggestions.

razorsedge commented 10 years ago

d15cca7 is an example of what I did for SLES support in my razorsedge/cloudera repo.

razorsedge commented 9 years ago

Merged in SLES support in commit aae2614478b4ba9a6739a6cac97e4f31b874822d.

razorsedge commented 9 years ago

Released to the Forge as version 4.9.0.