search

voxpupuli / puppet-vmwaretools

Puppet module to manage VMware Operating System Specific Packages for VMware tools installation.
http://forge.puppetlabs.com/razorsedge/vmwaretools
Apache License 2.0
34 stars 44 forks source link

VMWareTools OSP 5.0 series support #3

Closed geoffdavis closed 12 years ago

geoffdavis commented 12 years ago

I have what I think is working support for the 5.0 series of VMWare Tools. Tested only on CentOS6.2 running under ESX 5.0

VMWare changed their signing keys so there's now a DSA signing key and an RSA signing key.

I also refactored the vmwaretools::ntp class to work with the parameterized main class. This includes the suggestion that uses set the notify to be on Class['vmwaretools::ntp'] instead of on Exec['vmware-tools.timeSync'].

I'm not familiar with rspec at all, so I'd appreciate a bit of help with updating the tests to work. EDIT: I now have rspec tests included.

razorsedge commented 12 years ago

Sorry this is taking so long to review/merge... life has gotten in the way.

razorsedge commented 12 years ago

I am working on writing up rspec tests for this.

geoffdavis commented 12 years ago

I've got the existing tests working at this point. I still need to get some tests going for my added logic to handle the 5.x series.

geoffdavis commented 12 years ago

5.x tests in place