added gpgkey_url parameter

voxpupuli / puppet-vmwaretools

Puppet module to manage VMware Operating System Specific Packages for VMware tools installation.

http://forge.puppetlabs.com/razorsedge/vmwaretools

Apache License 2.0

34 stars 44 forks source link

added gpgkey_url parameter #31

Closed acjohnson closed 9 years ago

acjohnson commented 9 years ago

This turns the $gpgkey_url variable into a parameter that the user can then specify a custom URL to the GPG key in case the GPG key is not hosted under the previously assumed URLs: ${yum_server}${yum_path}/keys/ or ${yum_server}${yum_path}/

acjohnson commented 9 years ago

The unit tests on this module appear to be out of date. It is complaining about this line unless $gpgkey_url { $gpgkey_url = "${yum_server}${yum_path}/keys/" } but this passes puppet parser validate and I've tested with puppet v3.0 and newer.

@razorsedge, any reasons not to merge this?

razorsedge commented 9 years ago

@acjohnson The unit tests are out of date because you have changed the behaviour of the code. :-)

A few things:

The default value of gpgkey_url should be the module's current, hard-coded default.
Please add unit tests to exercise the new gpgkey_url parameter.
Please re-submit a PR against the develop branch as that is where the latest code resides.