search

voxpupuli / puppet-vmwaretools

Puppet module to manage VMware Operating System Specific Packages for VMware tools installation.
http://forge.puppetlabs.com/razorsedge/vmwaretools
Apache License 2.0
34 stars 44 forks source link

NTP woes #4

Closed ryanycoleman closed 12 years ago

ryanycoleman commented 12 years ago

Hi,

As it stands, it looks like the $vmwaretools::service_pattern selector match may not have up-to-date values. Do you know of any reference to the service name for each version of the tools?

Also, why include the vmwaretools class from inside ntp? This prevents users from declaring the vmwaretools class with the specific parameters they might want to tweak (like autoupgrade). It seems more flexible to remove that include and either make the exec subscribe to the vmwaretools class or make that activity a resource type that we can use in an idempotent fashion.

What do you think?

razorsedge commented 12 years ago

Are you working with 4.0.2 or the new 4.1.0?

ryanycoleman commented 12 years ago

Thanks @razorsedge, I hadn't realized 4.1.0 came out. This resolved my concerns but led to another. I'll file another issue against that.