search

voxpupuli / puppetboard

Web frontend for PuppetDB
https://pypi.org/project/puppetboard/
Apache License 2.0
710 stars 237 forks source link

Fix offline #1124

Open VolJin opened 3 months ago

VolJin commented 3 months ago

Fix for https://github.com/voxpupuli/puppetboard/issues/988 When using offline mode, the puppetboard tries to load external resources.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 76.87%. Comparing base (e3b8b09) to head (e7cf521).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1124 +/- ## ======================================= Coverage 76.87% 76.87% ======================================= Files 20 20 Lines 1310 1310 ======================================= Hits 1007 1007 Misses 303 303 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yakatz commented 2 months ago

Manually changing the included CSS from another library doesn't seem like a good idea - it will get overwritten next time the library is updated. Adding an NPM build is probably the better option.