vr4vet / Blue-Sector

Virtual Reality app for exploring blue sector workplaces and professions.
MIT License
2 stars 0 forks source link

Ff improve qa layout #440

Closed mefriis closed 2 months ago

mefriis commented 2 months ago
mefriis commented 2 months ago

Looks good. The intersection above the gutting station (where the fish should come from) should be replaced with a box/device that despawns fish from sorting station and spawns new fish for the gutting station when the gutting station is activated. Could this PR also implement that? Should go under "fix intersection" task.

There is a despawner and spawner in the "LightningBox". The fish goes from the two sorting stations, onto the long conveyor down the slide and then despawns. New fish spawns in the "LigthningBox" once the gutting sorting task is started. This can be done with some other "box" of course.

jonp-h commented 2 months ago

Looks good. The intersection above the gutting station (where the fish should come from) should be replaced with a box/device that despawns fish from sorting station and spawns new fish for the gutting station when the gutting station is activated. Could this PR also implement that? Should go under "fix intersection" task.

There is a despawner and spawner in the "LightningBox". The fish goes from the two sorting stations, onto the long conveyor down the slide and then despawns. New fish spawns in the "LigthningBox" once the gutting sorting task is started. This can be done with some other "box" of course.

Would it make more sense to see the fish enter the gutting box instead of spawning within it?

mefriis commented 2 months ago

Looks good. The intersection above the gutting station (where the fish should come from) should be replaced with a box/device that despawns fish from sorting station and spawns new fish for the gutting station when the gutting station is activated. Could this PR also implement that? Should go under "fix intersection" task.

There is a despawner and spawner in the "LightningBox". The fish goes from the two sorting stations, onto the long conveyor down the slide and then despawns. New fish spawns in the "LigthningBox" once the gutting sorting task is started. This can be done with some other "box" of course.

Would it make more sense to see the fish enter the gutting box instead of spawning within it?

Good point. I will make a despawn/spawn functionality before the gutting box.

jonp-h commented 2 months ago

Looks good. The intersection above the gutting station (where the fish should come from) should be replaced with a box/device that despawns fish from sorting station and spawns new fish for the gutting station when the gutting station is activated. Could this PR also implement that? Should go under "fix intersection" task.

There is a despawner and spawner in the "LightningBox". The fish goes from the two sorting stations, onto the long conveyor down the slide and then despawns. New fish spawns in the "LigthningBox" once the gutting sorting task is started. This can be done with some other "box" of course.

Edit: I think I understand what you mean now. If there is fish going into the gutting machine then the PR is good to merge :)

mefriis commented 2 months ago

Looks good. The intersection above the gutting station (where the fish should come from) should be replaced with a box/device that despawns fish from sorting station and spawns new fish for the gutting station when the gutting station is activated. Could this PR also implement that? Should go under "fix intersection" task.

There is a despawner and spawner in the "LightningBox". The fish goes from the two sorting stations, onto the long conveyor down the slide and then despawns. New fish spawns in the "LigthningBox" once the gutting sorting task is started. This can be done with some other "box" of course.

Edit: I think I understand what you mean now. If there is fish going into the gutting machine then the PR is good to merge :)

Fish from the two grading machines are gathered on one conveyor, and then they slide off into the gutting machine where they despawn as they enter. New fish spawn in the machine when the gutting sorting task starts.