vsce-toolroom / vscode-textmate-languageservice

Language APIs and support features from Textmate tokenization in Visual Studio Code.
Other
13 stars 0 forks source link

[merged] [pull] Prevent per-line symbol duplication in outline service (document symbol provider) #29

Closed zm-cttae closed 1 year ago

zm-cttae commented 1 year ago

Merges hotfix-outline-decremented-collisions -> release-candidate/1.1.0

๐Ÿ—๏ธ Pull Request

๐Ÿ‘ท๐Ÿพโ€โ™€๏ธ Fixes

Fixes #12.

Description

When another symbol is pushed on the same line in the outline service, any symbols on the same line are decremented. This is seen incorrectly in the output of the document symbol provider.

What changes have you made?

Hotfix for line number collisions between entry symbols in the editor outline service.

What tests have you completed?

Anything else worth mentioning?

zm-cttae commented 1 year ago

enabled an automatic merge when the pipeline for 5af116bde5b119fa8de0401b9516166cf2d131d4 succeeds

zm-cttae commented 1 year ago

aborted the automatic merge because source branch was updated

zm-cttae commented 1 year ago

added 1 commit

  • fc06321c - Update test data for #12 (outline entry lineno collision)

Compare with previous version

zm-cttae commented 1 year ago

๐Ÿ˜ฉ custom assert impl is broken, currently refactoring test/util/jsonify.ts to use MockExtensionContext.

zm-cttae commented 1 year ago

added 1 commit

  • afced294 - Remove support for JSONC

Compare with previous version

zm-cttae commented 1 year ago

added 1 commit

  • b28b8260 - Add missing void check in TOC entry -> symbol conversion

Compare with previous version

zm-cttae commented 1 year ago

added 1 commit

  • db851d9d - [nit] [ci] Fix extension activation delay in test log

Compare with previous version

zm-cttae commented 1 year ago

added 1 commit

  • 084e958d - Remove comments from patched config

Compare with previous version

zm-cttae commented 1 year ago

added 1 commit

  • fc57e167 - [nit] Name output after vscode.ProviderResult

Compare with previous version

zm-cttae commented 1 year ago

added 1 commit

  • 86490c0a - [nit] Typo in comment

Compare with previous version

zm-cttae commented 1 year ago

added 1 commit

  • 6c2c1463 - Fix web runner

Compare with previous version

zm-cttae commented 1 year ago

added 1 commit

  • b162d4e6 - [nit] [lint] Move public `provideDefinition(...)` to top

Compare with previous version

zm-cttae commented 1 year ago

added 1 commit

  • ae209b58 - Rewrite entire test suite to work & scale to webworker

Compare with previous version

zm-cttae commented 1 year ago

added 1 commit

  • 97feb829 - Update test suite for ae209b5 rewrite

Compare with previous version

zm-cttae commented 1 year ago

mentioned in commit c125e1a1bc6a73099526f51623a1df7987ce5c55