vspinu / zotelo

Manage zotero collections from emacsemacs.
121 stars 8 forks source link

Fix path bug on cygwin. #11

Closed ArthurTu closed 11 years ago

ArthurTu commented 11 years ago

This fix issue #10.

I felt dirty to write a bunch of backslashes.

vspinu commented 11 years ago

Thanks for this. Could you please add one more change, move the cygwin check and (setq bibfile ... upper into the setq bibfile at line 388. I don't want to do it myself because I cannot test.

Thanks.

ArthurTu notifications@github.com on Sun, 28 Apr 2013 04:40:26 -0700 wrote:

This fix issue #10. I felt dirty to write a bunch of backslashes. You can merge this Pull Request by running:

git pull https://github.com/ArthurTu/zotelo master

Or you can view, comment on it, or merge it online at:

https://github.com/vitoshka/zotelo/pull/11

-- Commit Summary --

  • Add Cygwin support. Convert *unix-like path to windows path before it is passed to javascripts. Do remember to escape the backslash.

-- File Changes --

M zotelo.el (5)

-- Patch Links --

https://github.com/vitoshka/zotelo/pull/11.patchhttps://github.com/vitoshka/zotelo/pull/11.diff

ArthurTu commented 11 years ago

I moved the code to line 392, under the use of convert-standard-filename, because convert-file-name on cygwin is used to generate *unix-style path.

Anything like C:\book will be converted into C!ook by convert-standard-filename, which is really weird.