vye16 / slahmr

MIT License
459 stars 50 forks source link

Rerun visualization #10

Open roym899 opened 1 year ago

roym899 commented 1 year ago

Hi,

Sorry for the delay with this PR, I had some personal issue to deal with last week.

Anyway, main point of this PR is to add an interactive visualization using rerun. See this twitter thread for an example what can be done with it.

I made some other changes mainly related to packaging and dependencies:

I'm quite sure these are good changes, but let me know if you would prefer these changes to be separate PRs or if you prefer to keep the current state.

The rerun vis currently uses PyTorch3D to compute vertex normals, I saw you removed PyTorch3D as a dependency, I guess to avoid installation issues. For me installing PyTorch3D from source via pip instead of via conda typically works quite reliably (see current env.yaml). I can also replace it with another alternative if you prefer not to have PyTorch3D.

I think currently (also in main) there is an issue with install.sh. The conda environment used in that script does not include cuda-toolkit / nvcc, so it relies on system-wide cuda being available. I think it would be better if the install.sh would just use conda env create -f env.yaml otherwise there are two slightly different setups right now.

Might also be good to update the env_build.yaml before merging.