Closed nikicc closed 2 years ago
Merging #73 (10fdc74) into master (ad0868d) will decrease coverage by
0.18%
. The diff coverage is60.00%
.:exclamation: Current head 10fdc74 differs from pull request most recent head 815e4ae. Consider uploading reports for the commit 815e4ae to get more accurate results
@@ Coverage Diff @@
## master #73 +/- ##
==========================================
- Coverage 95.19% 95.01% -0.19%
==========================================
Files 7 7
Lines 957 962 +5
==========================================
+ Hits 911 914 +3
- Misses 30 32 +2
Partials 16 16
Impacted Files | Coverage Δ | |
---|---|---|
openapi/types.go | 100.00% <ø> (ø) |
|
openapi/generator.go | 94.00% <60.00%> (-0.27%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ad0868d...815e4ae. Read the comment docs.
Thanks for the PR. I added a few comments to ammend some parts of the implementation proposal that I wrote in the issue after thinking about it properly.
@nikicc One more comment, and we should be done. Could you please squash the commits into a single one? I'll merge ASAP and release in stride.
Could you please squash the commits into a single one?
Squashed & pushed now.
I'll merge ASAP and release in stride.
Thanks!
@nikicc LGTM, you can squash again.
Fixes #72.