wI2L / fizz

:lemon: Gin wrapper with OpenAPI 3 spec generation
https://pkg.go.dev/github.com/wI2L/fizz
MIT License
214 stars 52 forks source link

Support providing examples for custom types #73

Closed nikicc closed 2 years ago

nikicc commented 2 years ago

Fixes #72.

codecov[bot] commented 2 years ago

Codecov Report

Merging #73 (10fdc74) into master (ad0868d) will decrease coverage by 0.18%. The diff coverage is 60.00%.

:exclamation: Current head 10fdc74 differs from pull request most recent head 815e4ae. Consider uploading reports for the commit 815e4ae to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
- Coverage   95.19%   95.01%   -0.19%     
==========================================
  Files           7        7              
  Lines         957      962       +5     
==========================================
+ Hits          911      914       +3     
- Misses         30       32       +2     
  Partials       16       16              
Impacted Files Coverage Δ
openapi/types.go 100.00% <ø> (ø)
openapi/generator.go 94.00% <60.00%> (-0.27%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ad0868d...815e4ae. Read the comment docs.

wI2L commented 2 years ago

Thanks for the PR. I added a few comments to ammend some parts of the implementation proposal that I wrote in the issue after thinking about it properly.

wI2L commented 2 years ago

@nikicc One more comment, and we should be done. Could you please squash the commits into a single one? I'll merge ASAP and release in stride.

nikicc commented 2 years ago

Could you please squash the commits into a single one?

Squashed & pushed now.

I'll merge ASAP and release in stride.

Thanks!

wI2L commented 2 years ago

@nikicc LGTM, you can squash again.