wakarimasenco / ChanExplorer

MIT License
11 stars 3 forks source link

A couple of small points #2

Closed dalb8 closed 10 years ago

dalb8 commented 10 years ago

I just built the app using the recipe on gitorious. I find it very well designed and implemented. Just wanted to point out a couple of things.

-Update Project:Yes
+Srclibs:ActionBarSherlock
+
+Prepare:android update project -p . -t android-14 && rm src/com/slidingmenu/lib/app/SlidingMapActivity.java libs/actionbarsherlock-plugin-maps-4.1.0.jar
miyachan commented 10 years ago
  1. I'm aware of the error, would appreciate if you opened it in a separate issue.
  2. The film strip is badly implemented and can be disabled. I probably won't fix.
  3. I believe there are some text size options, if I have this right you want a larger option? (would appreciate if you opened it in a separate issue.)
  4. It doesn't use SSL except to post (see /src/co/wakarimasen/chanexplorer/Http.java). I don't particularly have a hard on for SSL, especially for something like 4Chan - and I haven't seen the need for it. If anything I'd prefer to have it off for energy usage and processing sake.
  5. The APK won't build without forcing target=19
  6. Thats been removed in the latest recipe.
  7. Wontfix/When I get to it/Make a PR.
dalb8 commented 10 years ago

Yes, I'll open a new issue.

The app does build without forcing target if you have Google APIs 14 installed, but f-droid deleted those from their config last month.