search

wallpants / pantsdown

Markdown to "GitHub HTML" parser
https://wallpants.github.io/pantsdown/
Other
4 stars 1 forks source link

Support for additional GitHub alerts #179

Closed froi closed 6 months ago

froi commented 6 months ago

Hello 👋🏼

Great project, I found it using github-preview.nvim.

I noticed that there's two alerts not directly supported here: TIP and CAUTION. It'd be great if this was added. I'm happy to take a stab at a PR if you are accepting them.

My thought was to add Caution and Tip to these variants and add the icon from octicons to the icons export.

No worries if you're not accepting PRs now and looking forward to see these projects grow.

wallpants commented 6 months ago

Hey there! Thanks for checking out the project and for the kind words.

I'd definitely welcome a PR to add support for TIP and CAUTION alerts. I'd rather not add new dependencies to the project, so if we could get the icons in without adding a dependency that'd be great.

demo should also get updated to include the new alerts.

Feel free to submit a PR if you have the time and bandwidth. Any contributions are much appreciated! Just let me know if you run into any issues.

froi commented 6 months ago

Cool. I already have something done but would want to test it first. Might take me longer to test than do 😅

I'll make a submission when ready.