search

wandersoncferreira / code-review

Code Reviews in Emacs
https://wandersoncferreira.github.io/code-review/
GNU General Public License v3.0
462 stars 50 forks source link

Github: Ability to review a PR without leaving a feedback message #189

Closed ktfleming closed 2 years ago

ktfleming commented 2 years ago

In the Github web UI, you can review a PR by adding various comments on particular changes, and then submitting the review (choosing the "comment" option) without writing a specific feedback message -- just leaving the comment text area blank.

In code-review though, trying to submit the review (via r c) without feedback results in the error "You must provide a feedback msg before submit your Review."

Would it be possible to allow submitting review with no feedback message, just individual comments, as it seems that Github allows this?

ktfleming commented 2 years ago

Trying this locally, changing code-review--submit-feedback-required?:

diff --git a/code-review-actions.el b/code-review-actions.el
index 6b1c549..2b80774 100644
--- a/code-review-actions.el
+++ b/code-review-actions.el
@@ -95,7 +95,8 @@
   (and (not (oref review-obj feedback))
        (not (string-equal (oref review-obj state) "APPROVE"))
        (not (and (string-equal (oref review-obj state) "COMMENT")
-                 (code-review-gitlab-repo-p (oref review-obj pr))))))
+                 (or (code-review-github-repo-p (oref review-obj pr))
+                     (code-review-gitlab-repo-p (oref review-obj pr)))))))

 ;;;###autoload
 (defun code-review--submit (event &optional feedback only-reply?)

seems to make the feedback-less review work for Github, perhaps that's all that's needed?

wandersoncferreira commented 2 years ago

Yes @ktfleming , this is all needed. Could you open a PR with this change?

I already tackled this issue some time ago and I remember that only the APPROVE option was possible to send without a feedback message. But I tried again today and you are right. I might be sleeping :/

Thanks for looking into it.

ktfleming commented 2 years ago

Sure, I’ll open a PR soon when I’m back at my PC!

On Fri, Jan 7, 2022 at 20:45 bartuka @.***> wrote:

Yes @ktfleming https://github.com/ktfleming , this is all needed. Could you open a PR with this change?

I already tackled this issue some time ago and I remember that only the APPROVE option was possible to send without a feedback message. But I tried again today and you are right. I might be sleeping :/

Thanks for looking into it.

— Reply to this email directly, view it on GitHub https://github.com/wandersoncferreira/code-review/issues/189#issuecomment-1007345214, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA4IBTBJCJZCOGNQYRQEWXDUU3G6PANCNFSM5LOCJZDQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

ktfleming commented 2 years ago

Created: https://github.com/wandersoncferreira/code-review/pull/190