search

wandersoncferreira / code-review

Code Reviews in Emacs
https://wandersoncferreira.github.io/code-review/
GNU General Public License v3.0
463 stars 51 forks source link

[Github] Freeze when trying to review a PR that includes an image in the description/comments #193

Open ktfleming opened 2 years ago

ktfleming commented 2 years ago

When I tried to use code-review to open/view my recent PR to this repo, https://github.com/wandersoncferreira/code-review/pull/190, it froze on the "Fetch Diff PR" step and I had to kill Emacs. Trying to review a few other PRs in this repo works fine. I found another PR in a different repo that also freezes: https://github.com/doomemacs/themes/pull/695

Both the PRs that freeze include an image in the description or a comment, so I have a feeling that's what's causing the problem, although I haven't been able to debug it yet to say for sure.

wandersoncferreira commented 2 years ago

@ktfleming I couldn't reproduce this issue. I can open both PRs you linked without any issue. The current version at master is using HTML to render the comments and description with support to rendering the images.

Screen Shot 2022-01-23 at 9 08 45 AM