search

wandersoncferreira / code-review

Code Reviews in Emacs
https://wandersoncferreira.github.io/code-review/
GNU General Public License v3.0
463 stars 51 forks source link

`magit-section-toggle` inconsistent when looking at file diffs #197

Open rschmukler opened 2 years ago

rschmukler commented 2 years ago

Describe the bug When using magit-section-toggle on a header under the files changed section, behavior can be inconsistent. Sometimes nothing happens (but then works if you run magit-section-toggle again), other times the wrong section toggles, or content expands above the active section. Sometimes subsections are not hidden. It seems like there could be an index error.

To Reproduce Visit a pull request with many diffs and changed files, then run magit-section-toggle and notice how behavior can be inconsistent.

Expected behavior Magit section toggle should work as reliably as in magit itself.

Screenshots Attached find a gif screencast. Note that I'm basically just moving the cursor around and running magit-section-toggle but you will see that behavior is somewhat inconsistent. This was done on https://github.com/clj-kondo/clj-kondo as an example.

output-2022-02-03-17:18:06

rschmukler commented 2 years ago

Upon further digging this may be a duplicate of #152