wandersoncferreira / code-review

Code Reviews in Emacs
https://wandersoncferreira.github.io/code-review/
GNU General Public License v3.0
462 stars 49 forks source link

can't add comment to PR #205

Open emacsbliss opened 2 years ago

emacsbliss commented 2 years ago

Describe the bug Got error:

eieio-oset--closql-oset: Wrong type argument: eieio-object, nil, obj

when trying to add single comment to PR

To Reproduce Steps to reproduce the behavior:

  1. M-x code-review-start, enter PR url
  2. in Code Review buffer, press r then s c
  3. in the Code Review Comment buffer, typed comment, press C-c C-c got error

If I type r followed by c, then will get this error instead:

Errors: "Unprocessable Entity. You need to leave a comment indicating the requested changes."

Expected behavior A comment should be sent to the PR

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Additional context I'm using enterprise github

codygman commented 2 years ago

This might be related to a bug I noticed that seemed to be because of either large sized comments with lots of code blocks and/or special characters.

okybr commented 2 years ago

I experience the same issue - I get the respective error messages in each of the two cases. How can I help trace the cause?

klochowicz commented 2 years ago

same issue here. Can reproduce on a public repo if needed, happy to join debugging efforts.

short-king commented 1 year ago

Getting this too. Has anyone had it work in some cases but not others? Example repos where it does and does not work would be helpful.

z80dev commented 8 months ago

also hitting the same behavior

prayner commented 3 months ago

and still seeing this.