wandersoncferreira / code-review

Code Reviews in Emacs
https://wandersoncferreira.github.io/code-review/
GNU General Public License v3.0
462 stars 49 forks source link

Prevent void-variable errors #207

Closed leungbk closed 2 years ago

leungbk commented 2 years ago

The value of code-review-actions--renamed must be known at macroexpansion time since it's used in a macro.

Also simplify slightly by removing code-review--define-obsolete-fns. define-obsolete-function-alias correctly makes commands interactive, so there is no need for a separate wrapper.

wandersoncferreira commented 2 years ago

Seems great @leungbk . Thank you for your contribution, today I learned something new =)

Could you add your name to CONTRIBUTORS.md file?