Open innerout opened 2 years ago
This might just be a cosmetic issue, see issue #48. Just be stubborn and proceed; I had to enter a user and confirm "set globally" three times. See the linked issue.
Thanks! I missed the issue you mentioned. The behavior you describe seems like mine, still having unexpected behavior makes the package counterintuitive to use. I believe if the package uses the variables mentioned in my first post, things will work as expected as in magit-forge.
Describe the bug code-review does not respect when the below variables are set. This seems to apply to github and gitlab custom instances as discovered by @gagbo in the doom emacs discord.
To Reproduce Steps to reproduce the behavior: Add this in your init.el
code-review-forge-pr-at-point
code-review
prepends gitlab. even whencode-review-gitlab-base-url
is set.Expected behavior Respect and concatenate code-review-gitlab-base-url with host and graphql-host properly.
Screenshots![image](https://user-images.githubusercontent.com/11080614/161437457-8cb9f22d-f4e4-4ead-a7ee-9f5831dc4d3d.png)
Desktop (please complete the following information):