wandersoncferreira / code-review

Code Reviews in Emacs
https://wandersoncferreira.github.io/code-review/
GNU General Public License v3.0
462 stars 49 forks source link

Use forge passwords #211

Open hjudt opened 2 years ago

hjudt commented 2 years ago

I am opening this issue as requested in https://github.com/wandersoncferreira/code-review/issues/48#issuecomment-1115552880

Instead of having to configure separate passwords (e.g. in ~/.authinfo.gpg), code-review should be able to use an existing forge configuration to avoid duplicate work for the user. See https://github.com/wandersoncferreira/code-review/issues/48#issuecomment-1088499842 for possible solutions.

Preferably, I'd just do without any additional custom option and just use the 'forge key to access the defined password. IMHO, a custom option would only be a good idea for current users of code-review that have set everything up, but that may not be that many at the moment.

Without any further modifications though, only relying on the forge set up will not be enough; code-review requires more entries than forge. So in another step, one should probably make code-review use forge-alist and use fewer entries for the servers (e.g. gitlab.com/api vs gitlab.com/api/v4 vs gitlab.com.