search

wandersoncferreira / code-review

Code Reviews in Emacs
https://wandersoncferreira.github.io/code-review/
GNU General Public License v3.0
462 stars 49 forks source link

Make auth login marker configurable #213

Closed hjudt closed 2 years ago

hjudt commented 2 years ago

code-review searches for authentication data in ~/.authinfo.gpg by looking for logins ending with "^code-review", like magit forge does with looking for logins ending with "^forge". Add a customization option to make code-review look and use those configured for forge, so that users of forge can use the entries they have configured already.

This fixes issue #211.

hjudt commented 2 years ago

Updated README.

wandersoncferreira commented 2 years ago

Awesome! Please fill the changelog and contributors files. I'll be merging this in a couple of hours, I need to go errand for a while.

Thanks again for this work, are you planning to work on the forge-alist to get the servers too? 💯 💯 💯

hjudt commented 2 years ago

I gave that forge-alist stuff a glance, but I recall I've had some questions about it. I will open a new issue for it, but not too soon.