search

wandersoncferreira / code-review

Code Reviews in Emacs
https://wandersoncferreira.github.io/code-review/
GNU General Public License v3.0
462 stars 49 forks source link

Fix suggestion code block #217

Closed RagnarGrootKoerkamp closed 2 years ago

RagnarGrootKoerkamp commented 2 years ago

Before, creating a suggestion would make a single row of three backticks, followed by a newline with a space and then the previous string. While it seems the closing backticks are not needed for GitHub to parse this correctly, adding them seems cleaner. The extra space seems unneeded here.

(Note: I didn't test this.)

shroomist commented 2 years ago

just stumbled on this buggy (maybe) behavior of no closing braces. along with the inability to create a suggestion for multiple lines.

wandersoncferreira commented 2 years ago

Thanks for your contribution @RagnarGrootKoerkamp . Sorry for the time it took for me to review and approve this. I'm trying to organize my time better so I can continue to work on this package more actively.

Could you please add your name to CONTRIBUTORS.md?

RagnarGrootKoerkamp commented 2 years ago

Thanks and done!