Start review could be async

wandersoncferreira / code-review

Code Reviews in Emacs

https://wandersoncferreira.github.io/code-review/

GNU General Public License v3.0

462 stars 49 forks source link

Start review could be async #219

Closed Andre0991 closed 2 years ago

Andre0991 commented 2 years ago

Hi!

First, thanks for the package, it looks great.

I used code-review-start and inserted a PR name (it's from an enterprise repo, so I can't share it, sorry). Then, I saw the "Fetching diff" message, but Emacs got stuck. I ended up having to force quit Emacs.

I'm wondering if that command was doing some sync operation and, if it's the case, if it would be implemented in a non-blocking way, such that while the diff is fetched one can still use Emacs.

Andre0991 commented 2 years ago

By the way, I think I can repro it consistently, at least with the current state of the PR.

Let me know what info I can send you for helping debugging that.

Andre0991 commented 2 years ago

I just realized that this is a dup of https://github.com/wandersoncferreira/code-review/issues/193 and/or https://github.com/wandersoncferreira/code-review/issues/196. Closing this.