search

wandersoncferreira / code-review

Code Reviews in Emacs
https://wandersoncferreira.github.io/code-review/
GNU General Public License v3.0
462 stars 49 forks source link

code-review-forge-pr-at-point fails after update #220

Closed thermopyle closed 1 year ago

thermopyle commented 2 years ago

Describe the bug I updated all Emacs packages today with auto-package-update, among the updated packages where magit. After the update I cannot any longer open a code review by placing point on a PR in magit forge's section "Pull requests awaiting review" and doing code-review-forge-pr-at-point. Doing so results in an error message.

To Reproduce Steps to reproduce the behavior:

  1. Update magit forge with 'N f f'.
  2. Place point on pull request in magit.
  3. Run code-review-forge-pr-at-point
  4. Results in error: 
    Fetch diff PR...80% 
deferred error : (wrong-type-argument sequencep shr-string-pixel-width)

Expected behavior The PR should have opened in a code-review buffer.

Desktop:

thermopyle commented 2 years ago

A complete reinstall of the code-review package seems to fix the problem. I've got it working now.