wandersoncferreira / code-review

Code Reviews in Emacs
https://wandersoncferreira.github.io/code-review/
GNU General Public License v3.0
462 stars 49 forks source link

Feature-Request: Close a PR without merging it #221

Open rolandtritsch opened 2 years ago

rolandtritsch commented 2 years ago

I noticed that in the actions menu you can only merge the PR, but not close it (with a comment) without merging it.

Would suggest to add that option (in the Review section).

image

logc commented 1 year ago

I would also like to have this feature. In fact, there is issue #65 about the same, which was closed without any comment (?). Is this not feasible?

Also, let me thank the author for this package. Just started to use it again and it makes my workflow much much easier.

zarthross commented 1 year ago

I would also like to see this option.

ag91 commented 2 weeks ago

I was playing around with this repo and I addressed (for github only) the issue on my fork (you can see I closed this PR a few times while testing https://github.com/ag91/code-review/pull/1).