search

wandersoncferreira / code-review

Code Reviews in Emacs
https://wandersoncferreira.github.io/code-review/
GNU General Public License v3.0
462 stars 49 forks source link

Error: `(wrong-type-argument sequencep listp)` on `code-review-start` #222

Open anonimitoraf opened 1 year ago

anonimitoraf commented 1 year ago

Hi, I'm really keen on using this package for my day job workflow but I get an error when I run code-review-start

Describe the bug On code-review-start, I get this error:

Decrypting /Users/raf/.authinfo.gpg...done
Fetch diff PR...20% 
deferred error : (wrong-type-argument sequencep listp)

To Reproduce Steps to reproduce the behavior:

  1. Set up (as per README) for github
  2. M-x code-review-start
  3. See error
  4. I've tried turning on debug-on-error but it doesn't give me a stacktrace on error which I guess is due to it being deferred

Desktop (please complete the following information):

gjnoonan commented 1 year ago

I get this same error, although mine gets to 50%. I was trying to pass in a bitbucket URL.

My emacs version string is

GNU Emacs 28.1 (build 2, x86_64-alpine-linux-musl, X toolkit, cairo version 1.17.4) of 2022-05-18
vibrys commented 1 year ago

thank you for package. unfortunately the same here.

vibrys commented 1 year ago

more light (deferred:default-cancel does get improper number of arguments?):

(reactions (nodes)) (comments (nodes)) (reviews (nodes)))))))
   41 QUEUE-POST [1]: (#s(deferred deferred:default-callback [code-review-utils--log code-review--build-buffer prin1-to-string sequencep string-prefix-p BUG: Unknown extended header: message Your PR might have diffs too large. Currently not supported. Got an error from your VC provider. Check `code-review-log-file'.] 5 

(fn ERR)] deferred:default-cancel nil nil nil) ng wrong-number-of-arguments (8 . 8) 6)
   42 EXEC : #s(deferred deferred:default-callback [code-review-utils--log code-review--build-buffer prin1-to-string sequencep string-prefix-p BUG: Unknown extended header: message Your PR might have diffs too large. Currently not supported. Got an error from your VC provider. Check `code-review-log-file'.] 5 

(fn ERR)] deferred:default-cancel nil nil nil) / ng / (wrong-number-of-arguments (8 . 8) 6)
   43 ERROR : (wrong-type-argument listp 8)

@gjnoonan, @anonimitoraf, please visit deferred:debug variable definition, change it to t, make sure deferred.elc has been recompiled. restart emacs and observe deferred-debug buffer

@wandersoncferreira, can I enlarge limit of diffs size somehow (as a workaround..)

regards, Vibrys

rynoV commented 1 year ago

Maybe try updating Magit and Forge to the latest versions, that fixed a similar issue for me.

SqrtMinusOne commented 7 months ago

I've found what caused this error in my case. I had to set the following variables like so to fix it:

(setq code-review-auth-login-marker 'forge)
(setq code-review-gitlab-base-url "<gitlab-instance>")
(setq code-review-gitlab-host "<gitlab-instance>/api")
(setq code-review-gitlab-graphql-host "<gitlab-instance>/api")

Unfortunately, this error can be caused in many different ways, which all look the same because of deferred.el. In my case, essentially any error in "code-review--build-buffer" looks like this.