search

wandersoncferreira / code-review

Code Reviews in Emacs
https://wandersoncferreira.github.io/code-review/
GNU General Public License v3.0
462 stars 49 forks source link

QUESTION: where should point be to make single top-level comment? (likely the issue given the error "funcall: Wrong type argument: eieio-object, nil, obj") #229

Open abbreviatedman opened 1 year ago

abbreviatedman commented 1 year ago

(And should documentation for this be added or made more discoverable?)

What I Did

Attempt to create and submit a single top-level comment using

  1. M-x code-review-submit-single-top-level-comment (or s c in the transient menu).
  2. Write a comment.
  3. Submit the comment with C-c C-c(code-review-comment-commit).

What Did I Expect To Have Happen?

A single comment is created in the GitHub PR.

What Happened Instead

An error occurred.funcall: Wrong type argument: eieio-object, nil, obj

No comment was created or submitted.

Theories

Could be a configuration issue on my side, but I believe the following error is from attempting to find the PR at point to add the comment to:

So:

  1. Is this a bug or user config error?
  2. Or (my guess) does the point need to be in a specific place to submit a top-level comment?

Any help is greatly appreciated!

Thaodan commented 1 year ago

I noticed the same issue.

prayner commented 3 months ago

And still seeing it. There haven't been new commits in that time so no surprise it's not fixed. Is anyone not seeing this behaviour and hence pointers to a workaround?