search

wandersoncferreira / code-review

Code Reviews in Emacs
https://wandersoncferreira.github.io/code-review/
GNU General Public License v3.0
462 stars 49 forks source link

Add http support #233

Closed AustinMooreT closed 1 year ago

AustinMooreT commented 1 year ago

This adds http support code-review can be used with insecure private instances.

wandersoncferreira commented 1 year ago

Thank you @AustinMooreT for this contribution. Could you please rename the variable to start with code-review- prefix? This will make it more aligned with elisp practices

AustinMooreT commented 1 year ago

The variable is a part of ghub and is used by the function ghub-request. Should I make a second variable for code-review-?

wandersoncferreira commented 1 year ago

@AustinMooreT I believe this is ok. I didn't know ghub had this variable available. It's nice because we keep sync with our dependency.

wandersoncferreira commented 1 year ago

Thank you for your contribution @AustinMooreT