Open phelrine opened 1 year ago
Thank you for the fix @phelrine. I'm using your fix/closql-update
branch util it gets merged, and it's working fine.
I too have been using this branch.
Same here 👍
Thank you to @phelrine for this fix!
Any idea if this will be merged in anytime?
@wandersoncferreira this patch resolves a breaking issue introduced in an upstream dependency; would you mind taking a look?
Thank you for the fix @phelrine!
Also for others who encounter this issue with spacemacs:
fix/closql-update
) (use-package code-review
:load-path "~/Projects/Personal/code-review"
:after magit forge emojify
:demand t
:config
(setq code-review-auth-login-marker 'forge)
(add-hook 'code-review-mode-hook #'emojify-mode)
(define-key forge-topic-mode-map (kbd "C-c r") 'code-review-forge-pr-at-point)
(define-key code-review-feedback-section-map (kbd "k") 'code-review-section-delete-comment)
(define-key code-review-local-comment-section-map (kbd "k") 'code-review-section-delete-comment)
(define-key code-review-reply-comment-section-map (kbd "k") 'code-review-section-delete-comment)
(define-key code-review-mode-map (kbd "C-c C-n") 'code-review-comment-jump-next)
(define-key code-review-mode-map (kbd "C-c C-p") 'code-review-comment-jump-previous))
SPC f e R
)The current main branch is broken, but this pull request works great!
UPDATE no.2: my bad: my config loaded the package from the wrong place... :facepalm:
Hi, the melpa version (20221206.113) doesn't have this fix and breaks with the current melpa magit closql package.
This pull request resolves an issue caused by breaking changes in closql (#245). The fix was implemented using a commit (https://github.com/magit/forge/commit/af9358dcad4c5146b359b1709184445ff05099db) as a reference.
Furthermore, there was another issue causing test failures due to changes in the return value of
-contains-p
(https://github.com/magnars/dash.el/commit/112aa7c251a7cf3e5d024e21f205cdba79df5a33#diff-51920e95310ebfbc1ae31709f3b95f89afffbf4f1a6e38e8b2b406e2fb6197eaR28-R29). This issue has also been resolved in this pull request.