search

wandersoncferreira / code-review

Code Reviews in Emacs
https://wandersoncferreira.github.io/code-review/
GNU General Public License v3.0
462 stars 49 forks source link

`code-review-forge-pr-at-point` gives `deferred error: (wrong-type-argument sequencep number-or-marker-p)` #247

Closed schradert closed 1 year ago

schradert commented 1 year ago

Describe the bug Running code-review-forge-pr-at-point from forge pull request buffer gives deferred error: (wrong-type-argument sequencep number-or-marker-p) and does not open the code-review buffer.

To Reproduce Exactly as stated above in description. I was using this tool successfully for a couple days. After changing pull request metadata and putting in some reviews and suggestions (there were various bugs with comments and suggestions I faced, so I also did some online) and coincidentally restarting emacs, I couldn't open the code-review buffer again because of this error.

Expected behavior It should open up the code-review buffer and not error like this.

Version M-x version:

GNU Emacs 28.2 (build 1, aarch64-apple-darwin22.3.0, NS appkit-2299.40 Version 13.2.1 (Build 22D68)) of 2023-06-15

doom version:

GNU Emacs     v28.2            nil
Doom core     v3.0.0-pre       grafted, HEAD -> master, origin/master, origin/HEAD 07fca786 2023-05-30 19:39:04 -0400
Doom modules  v23.03.0-pre     grafted, HEAD -> master, origin/master, origin/HEAD 07fca786 2023-05-30 19:39:04 -0400
...

Additional context I am definitely a (doom)emacs noob

schradert commented 1 year ago

Using M-x code-review-start with the PR URL does work correctly. I can obviously keep doing that for now. I also saw that the docstring for code-review-forge-pr-at-point says OUTDATED. Not sure what the plan is there. Maybe others have seen this same issue? Thanks for making such an awesome tool btw!

schradert commented 1 year ago

Oh I'm sorry, I didn't see #195 before. Will see what I can do.

schradert commented 1 year ago

Oh I'm sorry, I didn't see #195 before. Will see what I can do.

I think this can be considered a repeat, so I'll close. I have the exact same error message and no leads yet it seems.