search

wandersoncferreira / code-review

Code Reviews in Emacs
https://wandersoncferreira.github.io/code-review/
GNU General Public License v3.0
462 stars 49 forks source link

Slow on Large Pull Requests #248

Open jsoa-gp opened 1 year ago

jsoa-gp commented 1 year ago

Describe the bug Really slow on large Pull Requests (~1500 files). The process hits "Fetch diff PR ....80%" and hangs for about 20 minutes. There after the code review section loads and easily navigates. Adding a comment, then seems to refresh the entire section, taking another 20 minutes to then again be usable.

To Reproduce Steps to reproduce the behavior:

  1. Try to review a PR that has many files ~1000 files

Expected behavior Large PRs to load faster, perhaps asynchronously

Desktop (please complete the following information):

Additional context

I realize that this might be a rare scenario of that many files to diff, and github web is practically un-usable and takes too long to make comments. I had to resort to use vscode with GitHub's PR extension to sanely review the pull request.

ParetoOptimalDev commented 1 year ago

If you are able I would advise trying out emacs 29 with native compilation and seeing if it improves performance.