search

wanze / TemplateEngineTwig

A ProcessWire module adding Twig templates to the TemplateEngineFactory.
MIT License
12 stars 11 forks source link

Strange field label #14

Closed gmclelland closed 5 years ago

gmclelland commented 6 years ago

I'm not sure why, but I'm seeing a weird label when I visit the module's configuration page. See this image: twig

gmclelland commented 6 years ago

Strange... On another fresh install site, it shows correctly.

gmclelland commented 6 years ago

This is weird. No matter what I do, I can't get it show correctly. I've tried reinstalling a fresh copy and deleting this module from the TemplateCompiler's caches. I've also tried uninstalling and reinstalling this module and TemplateEngineFactory.

For some reason this module is getting compiled with Processwire's Compiler and I think the code generated is causing the problem?

But that seems weird that it would work on one test site and not the other?

gmclelland commented 6 years ago

Strange. I just upgraded another local site. It was working fine at TemplateEngineTwig 1.04, but after the upgrade to TemplateEngineTwig 1.10 I'm seeing the same weird labels in the image above.

gmclelland commented 6 years ago

With some help from Robin at https://processwire.com/talk/topic/19514-modules-page-gettting-compiled/, I was able to resolve this by adding a php comment in the module file. That forced the module to recompile and it no longer shows incorrectly.

He thinks it might be related to this core issue: https://github.com/processwire/processwire-issues/issues/98

gmclelland commented 6 years ago

I thought this was fixed, but I'm still seeing the issue on one site. I still think it may be Processwire's File Compiler that is causing the issue? We probably just need to wait and follow this issue https://github.com/processwire/processwire-issues/issues/98.

wanze commented 5 years ago

Nice catch, this is 100% related to the file compiler of ProcessWire. I am closing this one since this is a core issue.