search

waschinski / photo-stream

Self-hosted, super simple photo stream
https://github.com/waschinski/photo-stream
MIT License
449 stars 70 forks source link

Added option to show/hide RSS button #34

Closed oliverhihn closed 2 years ago

oliverhihn commented 2 years ago

Added the option to hide the RSS feed button by setting SHOW_RSS_BUTTON=0. To show the button, it has to be set 1.

waschinski commented 2 years ago

Hey thanks for requesting and submitting the PR for #33 :)

Would you mind slightly renaming the setting though? None of the other options that show or hide a button have button in the name so I think SHOW_RSS_FEED would be more in line with the existing naming scheme. What do you think?

Oh and one more small thing: the default value should probably be 1 instead of 0 in order to not mess up instances of existing users when upgrading.

oliverhihn commented 2 years ago

Done! Yes you are right about the name schema. And I also changed the default value to 1.

waschinski commented 2 years ago

Thank you very much!

oliverhihn commented 2 years ago

You welcome! Thank you, for this awesome application!