water-fountains / proximap

a responsive Angular 6 web app for finding nearby fountains
https://beta.water-fountains.org
Other
16 stars 10 forks source link

improvements to "contribution guide" of "Bildergalerie" #103

Open ralfhauser opened 5 years ago

ralfhauser commented 5 years ago

image

Here comes an example where the default google images really miss the target ;)

Clicking 2) should have the same effect as clicking on 1) - see item 7 of #56

ralfhauser commented 5 years ago

image

Here I would be lost. i) all fields are empty ii) the right target to place your pictures (wiki-commons) is not on the "Daten bearbeiten" List. iii) if possible, there should be a hint to create a "commons category" for those who have more than one picture

It would be great to be able to list numbered bullets of steps like 1) upload your pics to 2) reference them out of wikidata with attribute ... between the section "MetaDaten"and section "Daten Bearbeiten"

mmmatthew commented 5 years ago

The possibility of clicking the "plus" and getting the same behavior is tricky. See issue https://github.com/lukasz-galka/ngx-gallery/issues/212

It may be necessary to change the gallery library. i) all fields are empty because there is no data. We could hide the fields in such cases ii) There is no link to a wiki commons page, because no such page exists for the fountain (contrarily to osm and wikidata) iii) The hint is provided in the contribution guide

The numbered bullets of steps is quite long and is documented in the contribution guide.

ralfhauser commented 5 years ago

Re i) sounds good Re iii) agreed, wasn't aware the contribution guide is already context dependent

re ii) if no page in wiki commons exists, still link to there and suggest to create one

ralfhauser commented 5 years ago

Let's give "lukasz" a little bit more time

ralfhauser commented 5 years ago

From: Keller Stefan Sent: Montag, 7. Januar 2019 01:24

Lieber Ralf

[...] Sieht gut aus (geht auch an Matthew)! Folgender Feedback-Quickfix: [...] Und beim Bild mit grossem "+" hätte ich erwartet, dass man darauf klicken kann, um ein neues beizutragen (analog Button "beitragen").

ralfhauser commented 5 years ago

Re 2: stefan.keller@hsr.ch:

Wheelmap.org ist super-easy gemacht mit "Add images", siehe z.B. https://wheelmap.org/nodes/5355402819

ralfhauser commented 5 years ago

In "alle Bunneneigenschaften", image 3) mouse-over should show (URL), where the images are taken from

ralfhauser commented 5 years ago

image 4) this should open target=_new to the proper place, e.g. https://commons.wikimedia.org/wiki/Category:Schulhaus_Limmat,_Im_Hofe

mmmatthew commented 5 years ago

I am actually considering hiding this property altogether, because it is a derived property and not one that actually exists in OSM or Wikidata. The actual property that people can edit is the "wikimedia commons category". Another property that is currently listed but is just derived is the wikipedia summary text.

Proposal: 5) do not list image gallery as a property 6) move expensive image gallery creation (involves multiple calls to wikimedia commons) away from backend and into front-end, so that the information is fetched from the client's browser, lightening our processing load.

ralfhauser commented 5 years ago

Re 5) if "commons category" and "commons image" and "commons category quicklink" remain, that is fine Re 6) sure

ralfhauser commented 5 years ago

image 7) suggest to first search for the fountain-name in commons.wikimedia - for many (historic) fountains pictures are already there and just not linked to wikidata yet (especially if the wikidata item is recent - e.g. Fritschibrunnen in Luzern)