search

water-fountains / proximap

a responsive Angular 6 web app for finding nearby fountains
https://beta.water-fountains.org
Other
16 stars 9 forks source link

multiple times the same fountain #154

Open ralfhauser opened 5 years ago

ralfhauser commented 5 years ago

image image

ralfhauser commented 5 years ago

Shouldn't that be 212 of 212 ? image

ralfhauser commented 5 years ago

1) Please make sure fountains only appear once (in SQL, it is "distinct()" function) 2) please make a mouse-over explaining that "no date" are not included (relates to #173) 3) if date >= now, always include all fountains (relates to #173)

mmmatthew commented 5 years ago

Any indication how to reproduce this bug? I was not able to... https://beta.water-fountains.org/zurich?lang=de&queryType=byId&database=wikidata&idval=Q55170432

ralfhauser commented 5 years ago

steps to reproduce: i) select city basel ii) set date-slide to 2020 iii) in the search text, type "basi"

image

ralfhauser commented 5 years ago

BTW, it also happens with a more restrictive/realistic date image

ralfhauser commented 5 years ago

Basiliken-Brunnen in Basel really has 3 distinct locations, so the root cause might be the underlying osn/wikidata data

ralfhauser commented 5 years ago

But allschwilerplatz is another one image

ralfhauser commented 5 years ago

see also #135 - duplicate

ralfhauser commented 5 years ago

Neptun Lucerne is another one https://beta.water-fountains.org/lucerne?lang=de&queryType=byId&database=wikidata&idval=Q29785697

ralfhauser commented 5 years ago

Allschwiler PLatz, Basel still present 2 times (duplicate https://github.com/water-fountains/datablue/issues/26, #127 )