water-fountains / proximap

a responsive Angular 6 web app for finding nearby fountains
https://beta.water-fountains.org
Other
16 stars 9 forks source link

Using user defined icons to pindrop on maps #282

Open Biopticon opened 5 years ago

Biopticon commented 5 years ago

Hello,

Is it possible to use icons we designed to label map locations? For example, we are currently working on creating a map of water fountains in a town called Bergama in Turkey. Some of these fountains are from Hellenic, some from Roman and some from Ottoman times. If I create icons for each period fountains, I can label them accordingly on the map for increased visual effect. What do you think?

Cem

ralfhauser commented 5 years ago

1) You should upload the desired icons to commons wikimedia as suggested in https://github.com/water-fountains/proximap/issues/266 and put attributes in wikidata as in https://www.wikidata.org/wiki/Q64822020 2) in the wikidata entry of each fountain will have to add the statement "depicted by" (P1299) and reference the thumbnail's q-number

ralfhauser commented 5 years ago

From: Fatih Kurunaz Sent: Montag, 30. September 2019 10:16 To: Ralf Hauser Cc: 'Cem Girit'; Matthew Moy de Vitry

Hey Ralf,

These are the links of the icons:

Antiquity Period Fountains: https://commons.wikimedia.org/wiki/File:Icon_antiquity.png [[File:Icon antiquity.png|thumb|]]

Greek Priod Fountains: https://commons.wikimedia.org/wiki/File:Icon_greek.png [[File:Icon greek.png|thumb|]]

Ottoman Period Fountains: https://commons.wikimedia.org/wiki/File:Icon_ottoman.png [[File:Icon ottoman.png|thumb|]]

https://h2o.do/tr-be?l=en&i=Q67141536 and https://h2o.do/tr-be?l=en&i=Q68792383 fountains are from the antiquity period • https://h2o.do/tr-be?l=en&i=Q67141558 is rom the Greek period. • All the other fountains are from Ottoman period. Thanks for all!

Fatih KURUNAZ

mmmatthew commented 5 years ago

I would propose to indicate the period with a qualifying label, similar to the date or wheelchair access icons:

image

The Mapbox API is not designed to display images with any source in the place of circle markers. "Symbols" are an option, but (i) it is not possible to scale them depending on the map zoom level and (ii) the symbol images need to be preprocessed into a sprite sheet before display. So direct linking to an image on wikimedia is not possible with the current map setup.

https://stackoverflow.com/questions/42322746/adding-url-images-to-mapbox-gl-js-layers/42353982#42353982

https://docs.mapbox.com/mapbox-gl-js/style-spec/#layers-symbol

Biopticon commented 5 years ago

Hello Matthew,

            Certainly. Let’s not create extra work. I will ask Fatih to design based on the icon standards you have. Could please send us their specs so that he can do them right.

Sincerely,

Cem

From: mmmatthew notifications@github.com Sent: Tuesday, October 01, 2019 3:28 AM

I would propose to indicate the period with a qualifying label, similar to the date or wheelchair access icons:

https://user-images.githubusercontent.com/10126798/65942151-fd3f7880-e42c-11e9-9c21-6e80ad562931.png

The Mapbox API is not designed to display images with any source in the place of circle markers. "Symbols" are an option, but (i) it is not possible to scale them depending on the map zoom level and (ii) the symbol images need to be preprocessed into a sprite sheet before display. So direct linking to an image on wikimedia is not possible with the current map setup.

mmmatthew commented 5 years ago

Hi Cem, Just to make sure I was clear, here is a pic indicating where the period information would be:

image

If we go for this approach, the information will be visible in the list but not visible in the map view. (If a fountain is selected, then the information will also be visible below the fountain name.

image

We have some options to make the information more accessible: 3) we could add a filter with a dropdown to only display images of a certain period 4) we could display the information in the mouseover pop-up on the map: image

Question: would these options be must-haves or just nice to have?

Finally, I have the impression that simple text labels will be more intuitive than symbols. Symbols are only useful if they are easily recognizable (i.e. no reflection needed to understand them). Are there standard symbols for historical eras?

ralfhauser commented 5 years ago

Re 3) the filter could be image

or see https://github.com/water-fountains/proximap/issues/172

ralfhauser commented 4 years ago

and https://github.com/water-fountains/proximap/issues/248